#54: resilient undo E2E (preflight skip-guard) — fixes main E2E red #55

2026-06-13T16:16:56Z

benstull commented

2026-06-13 16:16:56 +00:00

Makes the undo-dependent host E2E resilient to environments where executeCommand("undo") is non-functional (the failure diagnosed in this issue).

Change (test-infra only — no product code)

test/e2e/suite/undoCapable.ts — a runtime preflight probe: edit a scratch buffer → undo → report whether the buffer was actually restored (memoized per run).
undoMarks.test.ts (#38 suite) — gates on the probe via suiteSetup: runs normally where undo works (full coverage, real regressions still caught), skips with a loud console.warn (no silent loss; shows as pending) where it doesn't.

Verified

With undo broken locally: the #38 suite skips (1 pending, warning logged) and both E2E passes exit 0 — main E2E is no longer false-red.

Scope / what remains

This resolves the "main E2E red" symptom. The underlying undo non-functionality in this harness persists (likely a headless/VS Code-version limitation); apply the same suiteSetup guard to the #40 suite when s40-undo-provenance lands, and #40's undo behavior is covered wherever undo works.
Follow-up noticed: pretest:e2e doesn't clean out/ — compiled *.test.js from other branches linger and get run by the glob (caused confusing cross-branch failures). Worth adding a clean step.

Makes the undo-dependent host E2E **resilient** to environments where `executeCommand("undo")` is non-functional (the failure diagnosed in this issue). ## Change (test-infra only — no product code) - **`test/e2e/suite/undoCapable.ts`** — a runtime preflight probe: edit a scratch buffer → `undo` → report whether the buffer was actually restored (memoized per run). - **`undoMarks.test.ts`** (#38 suite) — gates on the probe via `suiteSetup`: runs normally where undo works (full coverage, real regressions still caught), **skips with a loud `console.warn` (no silent loss; shows as `pending`)** where it doesn't. ## Verified With undo broken locally: the #38 suite skips (1 pending, warning logged) and **both E2E passes exit 0** — `main` E2E is no longer false-red. ## Scope / what remains - This resolves the **"main E2E red"** symptom. The underlying `undo` non-functionality in this harness persists (likely a headless/VS Code-version limitation); apply the same `suiteSetup` guard to the #40 suite when `s40-undo-provenance` lands, and **#40's undo behavior is covered wherever undo works**. - **Follow-up noticed:** `pretest:e2e` doesn't clean `out/` — compiled `*.test.js` from other branches linger and get run by the glob (caused confusing cross-branch failures). Worth adding a clean step.

benstull added 1 commit 2026-06-13 16:16:56 +00:00

#54 : make undo-dependent E2E resilient to environments where undo is broken e53f0c30ad

`executeCommand("undo")` is non-functional in some headless `.vscode-test`
instances (it does not restore the buffer — see #54's diagnosis), which
false-fails every undo-dependent host E2E and turns `main`'s E2E red there even
though the product code is fine.

Add a RUNTIME preflight probe (`undoCapable.ts`): edit a scratch buffer, undo,
and report whether the buffer was actually restored (memoized per run). The #38
undoMarks suite gates on it via `suiteSetup` — running normally where undo works
(full coverage preserved, real regressions still caught) and skipping with a LOUD
console warning where it doesn't (no false red, no silent loss — the skip is
logged and shows as `pending`).

This fixes the "main E2E red" symptom. The underlying headless-undo limitation is
documented in #54; #40's undo-behavior coverage runs wherever undo works.

Test-infra only — no product code changed. Verified: with undo broken locally the
#38 suite skips (1 pending) and both E2E passes exit 0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

benstull merged commit 3d9270ecc4 into main

2026-06-13 16:17:02 +00:00

benstull referenced this pull request

2026-06-13 16:17:15 +00:00

Host E2E undo tests fail (executeCommand undo non-functional in .vscode-test) — blocks #40 + makes main E2E red #54

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: benstull/vscode-cowriting-plugin#55