benstull/vscode-cowriting-plugin
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

F2: region-anchored threads on @cline/sdk (Feature #4) #5

Merged
benstull merged 7 commits from feat/f2-region-anchored-threads into main 2026-06-10 14:01:18 +00:00
Conversation 0 Commits 7 Files Changed 22
+4253 -19
benstull commented 2026-06-10 14:00:56 +00:00
Owner
Copy Link
Copy Source

Summary

Implements F2 (#4) — region-anchored discussion threads on the POC skeleton (#2), per vscode-cowriting-plugin-content/specs/coauthoring-inner-loop.md (§7.2 SLICE-1..5).

  • SLICE-1 src/model.ts — versioned artifact schema (shared anchors/provenance primitives, schemaVersion, empty attributions/proposals extension points for F3/F4 — INV-4) + stable, sorted serialization (INV-2). src/store.ts — CoauthorStore load/save of .threads/<doc>.json sidecars.
  • SLICE-2 src/anchorer.ts — hybrid anchoring: buildFingerprint, resolution ladder (exact-unique → context-disambiguated → lineHint tiebreak → orphaned, never guesses — INV-1/INV-3), live offset shift.
  • SLICE-3 src/threadController.ts wires Store + Anchorer + vscode-free src/threadModel.ts to vscode.comments (create-on-selection, reply, resolve, render); package.json contributes the commands/menus; extension.ts returns a test API.
  • SLICE-4 reload + FileSystemWatcher external re-anchor (with self-write guard) + orphaned-thread surface; decision logic locked by unit tests.
  • SLICE-5 @vscode/test-electron host E2E across create → reply → resolve → persist → reload → re-anchor → orphan.

No live @cline/sdk turn and no credentials in F2 (INV-5); cline.ts untouched.

Test Plan

  • npm test — 24 vitest unit tests green (schema, store, anchorer, thread mutations, re-anchor decisions, + existing SDK driver).
  • npm run typecheck — clean.
  • npm run build — out/extension.cjs builds.
  • npm run test:e2e — 4 host E2E tests green against VS Code 1.124.0.
  • Manual F5: select text → "Add Coauthoring Thread on Selection" → reply/resolve → reload → edit-and-orphan (see plan's operator checklist).

Plan: docs/superpowers/plans/2026-06-10-f2-region-anchored-threads.md.

🤖 Generated with Claude Code

## Summary Implements **F2 (#4) — region-anchored discussion threads** on the POC skeleton (#2), per `vscode-cowriting-plugin-content/specs/coauthoring-inner-loop.md` (§7.2 SLICE-1..5). - **SLICE-1** `src/model.ts` — versioned artifact schema (shared `anchors`/`provenance` primitives, `schemaVersion`, empty `attributions`/`proposals` extension points for F3/F4 — INV-4) + stable, sorted serialization (INV-2). `src/store.ts` — `CoauthorStore` load/save of `.threads/<doc>.json` sidecars. - **SLICE-2** `src/anchorer.ts` — hybrid anchoring: `buildFingerprint`, resolution ladder (exact-unique → context-disambiguated → lineHint tiebreak → **orphaned**, never guesses — INV-1/INV-3), live offset `shift`. - **SLICE-3** `src/threadController.ts` wires Store + Anchorer + vscode-free `src/threadModel.ts` to `vscode.comments` (create-on-selection, reply, resolve, render); `package.json` contributes the commands/menus; `extension.ts` returns a test API. - **SLICE-4** reload + `FileSystemWatcher` external re-anchor (with self-write guard) + orphaned-thread surface; decision logic locked by unit tests. - **SLICE-5** `@vscode/test-electron` host E2E across create → reply → resolve → persist → reload → re-anchor → orphan. No live `@cline/sdk` turn and no credentials in F2 (INV-5); `cline.ts` untouched. ## Test Plan - [x] `npm test` — 24 vitest unit tests green (schema, store, anchorer, thread mutations, re-anchor decisions, + existing SDK driver). - [x] `npm run typecheck` — clean. - [x] `npm run build` — `out/extension.cjs` builds. - [x] `npm run test:e2e` — 4 host E2E tests green against VS Code 1.124.0. - [ ] Manual F5: select text → "Add Coauthoring Thread on Selection" → reply/resolve → reload → edit-and-orphan (see plan's operator checklist). Plan: `docs/superpowers/plans/2026-06-10-f2-region-anchored-threads.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
benstull added 7 commits 2026-06-10 14:00:57 +00:00
F2: just-in-time implementation plan for region-anchored threads (#4) 9c9d4928bd 
Plan derived from vscode-cowriting-plugin-content/specs/coauthoring-inner-loop.md
§7.2 (SLICE-1..5). UI surface ⇒ @vscode/test-electron host E2E is a first-class
plan task, not a follow-up.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
F2 SLICE-1: artifact schema + CoauthorStore with round-trip tests (#4) 9d93ccca19 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
F2 SLICE-2: Anchorer (fingerprint, resolution ladder, live shift) (#4) e5817eef0a 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
F2 SLICE-3: ThreadController on the Comments API + thread mutations (#4) 1bc7a369b7 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
F2 SLICE-4: lock reload/re-anchor/orphan decision logic with unit tests (#4) 2a9c198859 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
F2 SLICE-5: @vscode/test-electron host E2E (create→reload→re-anchor→orphan) (#4) 4ce6c9da52 
Drives the extension's returned ThreadController API + asserts the on-disk
sidecar and rendered Comments state (spec §6.8 fallback). All 4 host tests
green against VS Code 1.124.0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
F2: document region-anchored threads + test commands (#4) 40c118e1a0 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
benstull merged commit d8e6d4a328 into main 2026-06-10 14:01:18 +00:00
benstull deleted branch feat/f2-region-anchored-threads 2026-06-10 14:01:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
priority/P0
Priority: highest — drop everything
 priority/P1
Priority: high
 priority/P2
Priority: medium
 priority/P3
Priority: low / someday
 type/bug
A defect in shipped behavior
 type/epic
Type: a large body of work spanning many features
 type/feature
Type: a deliverable capability under an epic
 type/story
Type: a user story — the smallest valuable increment
 type/task
Type: a concrete unit of work under a story
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
benstull
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: benstull/vscode-cowriting-plugin#5
Delete Branch "feat/f2-region-anchored-threads"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?