F10: interactive track-changes review in the markdown preview (#29) #30

2026-06-12T07:39:33Z

benstull commented

2026-06-12 07:39:33 +00:00

Summary

F10 (#29) — interactive track-changes review in the markdown preview. Resolves the surface-collision friction (F6 raw diff + F3 attribution + F4 threads colliding on the same text) into one model: write left, review right.

Clean editor (INV-32): strip F3 attribution decorations + F4 in-editor proposal threads; hide F6 two-pane diff (ctrl+alt+d) and retire the attribution toggle. F3 spansFor, F4 accept/reject logic, and the F6 baseline stay as data layers.
One combined pure render (INV-33): new vscode-free renderReview(baseline, current, authorSpans, proposals) overlays the F7 baseline diff (added/changed prose author-colored via the salvaged F9 colorByAuthor sentinels; deletions struck) with pending F4 proposals as blue cw-proposal blocks carrying ✓/✗. Plus renderPlain for the off-state.
Interactive (INV-34): the preview collapses F9's two modes into one annotations on/off toggle; ✓/✗ post intent to the host, which routes through the existing F4 acceptById/rejectById seam — the webview never mutates the document. Status-bar indicator surfaces pending proposals when no preview is open (PUC-6).
Supersedes F9 INV-26 (authorship now combined with the diff; renderAuthorship + segmented control removed) and drops F6's any-file reach as a user goal (markdown-only).

Spec: specs/coauthoring-interactive-review.md (§7.2 slices SLICE-1..4). Plan: docs/superpowers/plans/2026-06-11-f10-interactive-review.md.

Known v1 deferral: resolved proposals render as trailing cw-proposal blocks rather than inline-at-anchor (spec §2/§6.2) — deterministic, never-dropped (INV-34); inline placement is a candidate follow-up.

Test Plan

npm test — 189 unit (vitest, vscode-free): renderReview/renderPlain/colorByAuthor incl. duplicate-block coloring + determinism.
npm run test:e2e — 46 + 5 host E2E green: open / annotations toggle / propose→accept→reject / clean-editor (INV-32) / hidden-F6 / status-bar (PUC-6).
npm run build — clean typecheck + webview bundle.
Manual webview smoke per docs/MANUAL-SMOKE-F10.md (visual + real ✓/✗ clicks — sealed sandbox, not E2E-asserted).

🤖 Generated with Claude Code

## Summary F10 (#29) — **interactive track-changes review in the markdown preview**. Resolves the surface-collision friction (F6 raw diff + F3 attribution + F4 threads colliding on the same text) into one model: **write left, review right**. - **Clean editor (INV-32):** strip F3 attribution decorations + F4 in-editor proposal threads; hide F6 two-pane diff (`ctrl+alt+d`) and retire the attribution toggle. F3 `spansFor`, F4 accept/reject logic, and the F6 baseline stay as **data layers**. - **One combined pure render (INV-33):** new vscode-free `renderReview(baseline, current, authorSpans, proposals)` overlays the F7 baseline diff (added/changed prose author-colored via the salvaged F9 `colorByAuthor` sentinels; deletions struck) **with** pending F4 proposals as blue `cw-proposal` blocks carrying ✓/✗. Plus `renderPlain` for the off-state. - **Interactive (INV-34):** the preview collapses F9's two modes into one **annotations on/off** toggle; ✓/✗ post intent to the host, which routes through the existing F4 `acceptById`/`rejectById` seam — the webview never mutates the document. Status-bar indicator surfaces pending proposals when no preview is open (PUC-6). - **Supersedes** F9 INV-26 (authorship now combined with the diff; `renderAuthorship` + segmented control removed) and drops F6's any-file reach as a user goal (markdown-only). Spec: `specs/coauthoring-interactive-review.md` (§7.2 slices SLICE-1..4). Plan: `docs/superpowers/plans/2026-06-11-f10-interactive-review.md`. **Known v1 deferral:** resolved proposals render as trailing `cw-proposal` blocks rather than inline-at-anchor (spec §2/§6.2) — deterministic, never-dropped (INV-34); inline placement is a candidate follow-up. ## Test Plan - [x] `npm test` — 189 unit (vitest, vscode-free): `renderReview`/`renderPlain`/`colorByAuthor` incl. duplicate-block coloring + determinism. - [x] `npm run test:e2e` — 46 + 5 host E2E green: open / annotations toggle / propose→accept→reject / clean-editor (INV-32) / hidden-F6 / status-bar (PUC-6). - [x] `npm run build` — clean typecheck + webview bundle. - [ ] Manual webview smoke per `docs/MANUAL-SMOKE-F10.md` (visual + real ✓/✗ clicks — sealed sandbox, not E2E-asserted). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

benstull added 17 commits 2026-06-12 07:39:33 +00:00

F10: implementation plan for interactive track-changes review (#29 ) 050bb21b84

Plan for #29 (F10) from specs/coauthoring-interactive-review.md — clean editor +
preview as the single interactive review surface (annotations on/off; ✓/✗ on
pending F4 proposals). 4 slices, 14 tasks.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-1: strip F3 attribution editor decorations (keep spansFor) (#29 ) 923dcc09d9

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-1: remove F4 in-editor proposal threads/decorations; bookkeeping via live/unresolved (#29 ) 743de78994

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-1: hide F6 diff command/keybinding + attribution toggle; retitle preview to 'Open Review Preview' (#29 ) 5ce8817b15

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-1: retire dead attribution toggle (visible/toggle/isVisible + command) 831710ed0c

Code-quality follow-up: with editor decorations gone (Task 1), the visibility
toggle was dead/misleading — nothing reads `visible`. Remove the field,
toggle()/isVisible(), the cowriting.toggleAttribution registration, and its
package.json command + palette declarations (spec §6.2 retires it). renderActive/
render stay — they refresh the orphan status bar on editor switch.
E2E toggle assertions (attribution.test.ts, noWorkspace.test.ts) are updated in SLICE-4.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-2: extract colorByAuthor from renderAuthorship sentinels (#29 ) ebe3d4bab5

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-2: add renderPlain off-state (#29 ) 0311ad89ba

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-2: add ProposalView + renderReview combined on-state render (#29 ) d59f22b22f

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-2: fix renderReview author-coloring for duplicate blocks; tidy renderReviewOp + escape proposal id (#29 ) bcacbf062d

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-3: remove superseded public renderAuthorship (salvaged into colorByAuthor) (#29 ) bda394ea4e

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-3: ProposalController.listProposals + onDidChangeProposals + keyFor (#29 ) fe45569218

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-3: preview on/off mode; take ProposalController; renderReview path + accept/reject routing (#29 ) f8b36c3452

Includes the PUC-6 status-bar indicator (updateStatus + show/dispose hooks)
since the constructor subscription references it (one file, no intermediate
broken build).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-3: webview on/off switch + ✓/✗ click→postMessage + proposal CSS (#29 ) 28c5e9d334

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-3: wire ProposalController into the review preview (#29 ) 604c558287

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-3: rename preview panel title to 'Review' (#29 ) 42d0ec155e

Code-quality polish: the webview panel title read 'Track changes: <name>' but
F10 makes the preview the single review surface. Match the 'Open Review Preview'
command rename.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-4: host E2E for interactive review (open/toggle/propose→accept→reject/clean-editor/hidden-F6/status); update obsolete F9/toggle suites (#29 ) cdeb41ede4

Adds test/e2e/suite/f10Review.test.ts covering the F10 flow: open preview
(mode "on", fresh baseline all-unchanged), type → cw-by-human span, propose →
cw-proposal block with ✓/✗, accept → lands + baseline advances + block clears,
reject → vanishes + doc untouched, toggle off → renderPlain has no cw- marks,
status-bar PUC-6 (indicator with no panel, hidden once opened), and the
clean-editor INV-32 facts (retired toggleAttribution, F6 ctrl+alt+d hidden).

Rewrites the obsolete F9 authorship-mode test as an F10 review test
(cw-by-claude in the on-state render; getMode defaults to "on"). Updates
attribution.test.ts (drops the retired isVisible/toggleAttribution toggle,
asserts the toggle is gone) and noWorkspace.test.ts (toggleAttribution +
acceptProposal/rejectProposal are retired, preview-only — INV-32).

Honesty fix in the status-bar seam: hideStatus() clears statusItem.text so
statusText() reports undefined when the indicator is hidden (it previously
returned its stale last value after a panel opened).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

F10 SLICE-4: manual smoke checklist + README F10 section (#29 ) 0f5bc1b4ce

Adds docs/MANUAL-SMOKE-F10.md (clean editor → edit → propose → ✓/✗ →
Annotations toggle → status-bar PUC-6 → theming → cleanliness) following the
F7/F9 smoke format. Adds the F10 "write left / review right" section to the
README feature list and notes F6's two-pane diff and F9's authorship view are
retained only as data layers, not separate user surfaces.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

benstull merged commit 4160890956 into main

2026-06-12 07:39:51 +00:00

benstull referenced this pull request

2026-06-12 07:40:10 +00:00

Interactive track-changes review in the markdown preview (clean editor + accept/reject) #29

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: benstull/vscode-cowriting-plugin#30