Fix EDH no-workspace command registration (#8) + selection context menus (#9) #10

2026-06-10T21:27:16Z

benstull commented

2026-06-10 21:27:16 +00:00

Release-blocking fix + small UX addition, found in post-F3 manual play.

#8 (bug, P0): with no workspace folder, activate() returned before registering any F2/F3 command → palette errored command 'cowriting.editSelection' not found; stock launch.json launched the EDH folderless, so plain F5 always hit it. Now: warning stubs register for every contributed command (folder open → window reload → real activation), and F5 opens the repo as the EDH workspace. New second E2E pass (no-folder launch) pins the regression.
#9 (task): right-click context menu entries for Ask Claude to Edit Selection and Add Coauthoring Thread on Selection, shown only when text is highlighted in a file-scheme editor.

Gate: typecheck clean · vitest 69/69 · both bundles · E2E 10/10 (workspace) + 3/3 (no-workspace).

Fixes #8. Fixes #9.

🤖 Generated with Claude Code

Release-blocking fix + small UX addition, found in post-F3 manual play. - **#8 (bug, P0):** with no workspace folder, `activate()` returned before registering any F2/F3 command → palette errored `command 'cowriting.editSelection' not found`; stock `launch.json` launched the EDH folderless, so plain F5 always hit it. Now: warning stubs register for every contributed command (folder open → window reload → real activation), and F5 opens the repo as the EDH workspace. New second E2E pass (no-folder launch) pins the regression. - **#9 (task):** right-click context menu entries for **Ask Claude to Edit Selection** and **Add Coauthoring Thread on Selection**, shown only when text is highlighted in a file-scheme editor. Gate: typecheck clean · vitest 69/69 · both bundles · E2E 10/10 (workspace) + 3/3 (no-workspace). Fixes #8. Fixes #9. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

benstull added 1 commit 2026-06-10 21:27:17 +00:00

Fix #8 : register warning stubs when no workspace folder; F5 opens the repo. Add selection context menus (#9 ) c0bae8c774

- extension.ts: with no folder open, every contributed coauthoring command now
  registers a warning stub ('open a folder first') instead of being absent —
  the palette no longer errors 'command not found'. Opening a folder reloads
  the window and re-activates with a real root.
- .vscode/launch.json: the EDH now opens the repo as its workspace, so plain
  F5 lands in a working state.
- package.json: editor/context menu entries for 'Ask Claude to Edit
  Selection' and 'Add Coauthoring Thread on Selection', shown only when text
  is highlighted in a file-scheme editor (editorHasSelection).
- E2E: second no-workspace pass (suite-no-workspace) pins the #8 regression.

Fixes #8. Fixes #9.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

benstull merged commit 747692a3d9 into main

2026-06-10 21:27:19 +00:00

benstull referenced this pull request

2026-06-10 21:32:13 +00:00

Fix #8 follow-up: EDH opens a committed sandbox/ playground (one-folder-one-window collision) #11

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: benstull/vscode-cowriting-plugin#10