Surface polish: batched Minor findings from the native-surfaces final review (#71) #75

2026-07-03T03:20:15Z

benstull commented

2026-07-03 03:20:15 +00:00

Lands all six batched Minor findings from the native-surfaces migration final whole-branch review (closes #71):

pin()/Mark Changes as Reviewed on a never-established doc now says "Run ✦ Coedit this Document with Claude first." instead of the git-tracked message (src/diffViewController.ts).
Orphaned cowriting.acceptProposal/cowriting.rejectProposal declarations (and their when: false palette entries) deleted from package.json.
cowriting.openReviewPreview editor/title entry uses resourceLangId like every sibling title entry (+ the E2E assertion that codified the old key).
README hygiene: F3 gets a superseded-commands banner; F7/F10 superseded banners note the Ctrl+Alt+R chord reassignment.
cowriting.createThread palette entry gated on selection+coediting, matching its editor/context entry.
gitBaseline reflog debounce timer cleared on dispose.

Plan: docs/superpowers/plans/2026-07-02-71-surface-polish.md. Verified: 312 unit + typecheck + build + host E2E green.

🤖 Generated with Claude Code

Lands all six batched Minor findings from the native-surfaces migration final whole-branch review (closes #71): 1. `pin()`/Mark Changes as Reviewed on a never-established doc now says "Run ✦ Coedit this Document with Claude first." instead of the git-tracked message (`src/diffViewController.ts`). 2. Orphaned `cowriting.acceptProposal`/`cowriting.rejectProposal` declarations (and their `when: false` palette entries) deleted from `package.json`. 3. `cowriting.openReviewPreview` editor/title entry uses `resourceLangId` like every sibling title entry (+ the E2E assertion that codified the old key). 4. README hygiene: F3 gets a superseded-commands banner; F7/F10 superseded banners note the `Ctrl+Alt+R` chord reassignment. 5. `cowriting.createThread` palette entry gated on selection+coediting, matching its editor/context entry. 6. `gitBaseline` reflog debounce timer cleared on dispose. Plan: `docs/superpowers/plans/2026-07-02-71-surface-polish.md`. Verified: 312 unit + typecheck + build + host E2E green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

benstull added 8 commits 2026-07-03 03:20:16 +00:00

fix: markReviewed on a never-established doc says 'coedit first', not 'git-tracked' (#71 item 1) c52abdd2e5

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chore: delete orphaned acceptProposal/rejectProposal declarations (#71 item 2) ef11b8712e

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: openReviewPreview title-menu when uses resourceLangId like its siblings (#71 item 3) af8a10fc2a

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: gate createThread palette entry on selection+coediting like its context-menu entry (#71 item 5) 837d008572

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

fix: clear reflog debounce timer on GitBaselineWatcher dispose (#71 item 6) 057bb93362

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs: F3 superseded-commands banner + stale-chord notes in F7/F10 banners (#71 item 4) 1b0ea86ddc

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs(plan): #71 surface-polish batch implementation plan d494d90dc7

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

test: reviewPanelMenu editor/title assertion follows the resourceLangId fix (#71 item 3) 52f75f5fcb

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

benstull merged commit 3e7ad58247 into main

2026-07-03 03:20:24 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: benstull/vscode-cowriting-plugin#75