Surface polish: batched Minor findings from the native-surfaces migration final review #71

New Issue

2026-07-02T22:52:52Z

benstull commented

2026-07-02 22:52:52 +00:00

Batched Minor findings from the native-surfaces migration's final whole-branch review (session 0065, plan 2026-07-01-native-surfaces-migration.md) — none merge-blocking, all small surface-polish items:

markReviewed misleading warning: pin() on a doc that never established (modes.get(key) === undefined) emits "this document is git-tracked — commit to advance" (src/diffViewController.ts ~148-153) — wrong message for a non-coedited/never-established doc; add an explicit not-coediting branch. (The palette when-gate was already tightened at merge.)
Orphaned command declarations: cowriting.acceptProposal / cowriting.rejectProposal declared in package.json (~85-93) but registered nowhere (asserted retired by noWorkspace.test.ts:42-43). Pre-existing cruft; delete the declarations.
when-key inconsistency: cowriting.openReviewPreview editor/title entry uses editorLangId where every sibling title entry uses resourceLangId (the correct key for title menus). One-token fix.
README F3 section drift: the F3 "Commands" block (README ~121-126) presents retired Cowriting: Toggle Attribution and palette-hidden "Ask Claude to Edit Selection" as current, and lacks the SUPERSEDED banner the F7/F9/F10/F11 sections got; the banner-marked sections also carry stale chord references. One hygiene pass.
cowriting.createThread palette entry ungated: silently no-ops when not coediting (returns undefined, no toast) — inconsistent with the "Run ✦ Coedit this Document with Claude first." warning used elsewhere; add the gate or the warning.
gitBaseline reflog debounce timer not cleared in dispose() (src/gitBaseline.ts ~117-121) — one-shot post-dispose repo.status().catch() at worst; clear it when next touching the file.

Batched Minor findings from the native-surfaces migration's final whole-branch review (session 0065, plan `2026-07-01-native-surfaces-migration.md`) — none merge-blocking, all small surface-polish items: 1. **`markReviewed` misleading warning:** `pin()` on a doc that never established (`modes.get(key) === undefined`) emits "this document is git-tracked — commit to advance" (`src/diffViewController.ts` ~148-153) — wrong message for a non-coedited/never-established doc; add an explicit not-coediting branch. (The palette when-gate was already tightened at merge.) 2. **Orphaned command declarations:** `cowriting.acceptProposal` / `cowriting.rejectProposal` declared in `package.json` (~85-93) but registered nowhere (asserted retired by `noWorkspace.test.ts:42-43`). Pre-existing cruft; delete the declarations. 3. **when-key inconsistency:** `cowriting.openReviewPreview` editor/title entry uses `editorLangId` where every sibling title entry uses `resourceLangId` (the correct key for title menus). One-token fix. 4. **README F3 section drift:** the F3 "Commands" block (README ~121-126) presents retired `Cowriting: Toggle Attribution` and palette-hidden "Ask Claude to Edit Selection" as current, and lacks the SUPERSEDED banner the F7/F9/F10/F11 sections got; the banner-marked sections also carry stale chord references. One hygiene pass. 5. **`cowriting.createThread` palette entry ungated:** silently no-ops when not coediting (returns undefined, no toast) — inconsistent with the "Run ✦ Coedit this Document with Claude first." warning used elsewhere; add the gate or the warning. 6. **`gitBaseline` reflog debounce timer** not cleared in `dispose()` (`src/gitBaseline.ts` ~117-121) — one-shot post-dispose `repo.status().catch()` at worst; clear it when next touching the file.

benstull added the type/task priority/P3 labels 2026-07-02 22:52:52 +00:00

benstull referenced this issue

2026-07-02 23:09:27 +00:00

Native surfaces migration — evolve the extension onto VS Code's native review surfaces (9-task plan, spec v0.2.1) #72

benstull referenced this issue from a commit

2026-07-03 03:20:05 +00:00

fix: markReviewed on a never-established doc says 'coedit first', not 'git-tracked' (#71 item 1)

benstull referenced this issue from a commit

2026-07-03 03:20:05 +00:00

chore: delete orphaned acceptProposal/rejectProposal declarations (#71 item 2)

benstull referenced this issue from a commit

2026-07-03 03:20:05 +00:00