F6 #34: delete the dead two-pane diff-view UI, keep the baseline data layer #37

2026-06-12T09:10:30Z

benstull commented

2026-06-12 09:10:30 +00:00

What

Removes the now-dead F6 two-pane vscode.diff view code. F10 (#29) made the rendered preview the single review surface and hid the F6 toggle (when:false); this deletes the unreachable view, keeping the F6 baseline data layer that F7/F10 depend on.

Removed (dead view)

DiffViewController: toggle, findDiffTab, epochLabel, isDiffOpen; the cowriting-baseline: content provider + BASELINE_SCHEME + baselineUri + the content-provider change emitter; the toggleDiffView command.
package.json: the toggleDiffView command, its commandPalette entry, and the ctrl+alt+d keybinding.

Kept (live baseline data layer — INV-18/19)

ensureBaseline / advance / pin / capture, getBaseline, baselineFilePath, onDidChangeBaseline, global-storage persistence, and the machine-landing auto-advance. F7/F10 read the baseline unchanged.

Deliberate deviation from the issue

Issue #34's acceptance listed removing pinDiffBaseline too — kept here. The canonical Solution Design (coauthoring-interactive-review.md §6.7) scopes the removal to the two-pane view only ("keep the controller + baseline store"); pin() lives in the baseline lifecycle (§6.4), never touches vscode.diff, and is exercised by live F7 baseline-reset tests. Where the P3 capture draft and the approved spec conflict, the spec wins (documentation-leads-automation). Removing it would also violate the issue's own "no F7/F10 behavior change" criterion.

Tests

E2E diffView suite: keeps the baseline-data-layer tests (open/advance/pin/persist/outside-folder/untitled), drops the two-pane view tests.
F10 + no-workspace suites: toggleDiffView now asserted absent (was declared-but-hidden); pinDiffBaseline asserted present.
194 unit + 49 E2E green; tsc --noEmit + npm run build clean.

Closes #34

🤖 Generated with Claude Code

## What Removes the now-dead F6 two-pane `vscode.diff` **view** code. F10 (#29) made the rendered preview the single review surface and hid the F6 toggle (`when:false`); this deletes the unreachable view, keeping the F6 **baseline data layer** that F7/F10 depend on. ## Removed (dead view) - `DiffViewController`: `toggle`, `findDiffTab`, `epochLabel`, `isDiffOpen`; the `cowriting-baseline:` content provider + `BASELINE_SCHEME` + `baselineUri` + the content-provider change emitter; the `toggleDiffView` command. - `package.json`: the `toggleDiffView` command, its `commandPalette` entry, and the `ctrl+alt+d` keybinding. ## Kept (live baseline data layer — INV-18/19) `ensureBaseline` / `advance` / `pin` / `capture`, `getBaseline`, `baselineFilePath`, `onDidChangeBaseline`, global-storage persistence, and the machine-landing auto-advance. F7/F10 read the baseline unchanged. ## Deliberate deviation from the issue Issue #34's acceptance listed removing `pinDiffBaseline` too — **kept** here. The canonical Solution Design (`coauthoring-interactive-review.md` §6.7) scopes the removal to the two-pane *view* only ("keep the controller + baseline store"); `pin()` lives in the baseline lifecycle (§6.4), never touches `vscode.diff`, and is exercised by live F7 baseline-reset tests. Where the P3 capture draft and the approved spec conflict, the spec wins (documentation-leads-automation). Removing it would also violate the issue's own "no F7/F10 behavior change" criterion. ## Tests - E2E `diffView` suite: keeps the baseline-data-layer tests (open/advance/pin/persist/outside-folder/untitled), drops the two-pane view tests. - F10 + no-workspace suites: `toggleDiffView` now asserted **absent** (was declared-but-hidden); `pinDiffBaseline` asserted present. - 194 unit + 49 E2E green; `tsc --noEmit` + `npm run build` clean. Closes #34 🤖 Generated with [Claude Code](https://claude.com/claude-code)

benstull added 1 commit 2026-06-12 09:10:31 +00:00

F6 #34 : delete the dead two-pane diff-view UI, keep the baseline data layer 3520397e41

F10 (#29) made the rendered preview the single review surface and hid the F6
two-pane vscode.diff view (command + ctrl+alt+d set when:false). This removes
that now-unreachable view code:

- DiffViewController: drop toggle/findDiffTab/epochLabel/isDiffOpen, the
  `cowriting-baseline:` TextDocumentContentProvider + BASELINE_SCHEME + baselineUri
  + the content-provider change emitter, and the toggleDiffView command. The
  baseline DATA layer is fully intact — ensureBaseline/advance/pin/capture,
  getBaseline, baselineFilePath, onDidChangeBaseline, persistence (INV-19), and
  the machine-landing auto-advance (INV-18) that F7/F10 consume.
- package.json: remove the toggleDiffView command, its commandPalette entry, and
  the ctrl+alt+d keybinding.
- E2E: diffView suite keeps the baseline-data-layer tests, drops the two-pane
  view tests; the F10 + no-workspace suites assert toggleDiffView is now absent
  (was: declared-but-hidden).

Deliberate deviation from the issue's literal acceptance: pinDiffBaseline is
KEPT. The canonical Solution Design (coauthoring-interactive-review.md §6.7)
scopes the removal to the two-pane VIEW only ("keep the controller + baseline
store"); pin() lives in the baseline lifecycle (§6.4), never touches vscode.diff,
and is exercised by live F7 baseline-reset tests. Where the P3 capture draft and
the approved spec conflict, the spec wins (documentation-leads-automation).

194 unit + 49 E2E green; typecheck + build clean. No F7/F10 behavior change.

Closes #34

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

benstull merged commit 1a52ac6cb4 into main

2026-06-12 09:10:38 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: benstull/vscode-cowriting-plugin#37