fix: proposal threads disable the dead reply input (decide-only, INV-12) #16

2026-06-11T06:26:24Z

benstull commented

2026-06-11 06:26:24 +00:00

Summary

Operator feedback while playing with F4: the proposal comment widget showed VS Code's default "Reply…" input, but no submit command is wired for cowriting.proposals — typed replies had nowhere to go. Proposals are decide-only (INV-12: ✓ Accept / ✗ Reject in the thread title bar); discussion belongs in a regular coauthoring thread.

vsThread.canReply = false on proposal threads — the dead input never renders
RenderedProposal.canReply exposed on the test-facing snapshot + host E2E assertion

Test plan

npm run typecheck clean
npx vitest run — 98 passed
npm run test:e2e — 18 + 3 passing (new canReply assertion included)

🤖 Generated with Claude Code

## Summary Operator feedback while playing with F4: the proposal comment widget showed VS Code's default "Reply…" input, but no submit command is wired for `cowriting.proposals` — typed replies had nowhere to go. Proposals are decide-only (INV-12: ✓ Accept / ✗ Reject in the thread title bar); discussion belongs in a regular coauthoring thread. - `vsThread.canReply = false` on proposal threads — the dead input never renders - `RenderedProposal.canReply` exposed on the test-facing snapshot + host E2E assertion ## Test plan - [x] `npm run typecheck` clean - [x] `npx vitest run` — 98 passed - [x] `npm run test:e2e` — 18 + 3 passing (new canReply assertion included) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

benstull added 1 commit 2026-06-11 06:26:24 +00:00

fix: proposal threads disable the reply input — decide-only, INV-12 4c947acc43

Playing with F4, the operator hit VS Code's default "Reply…" box on a
proposal thread: no submit command is wired for cowriting.proposals, so
typed text had nowhere to go. Proposals are decide-only (accept/reject in
the title bar); discussion belongs in a coauthoring thread. Set
canReply=false so the dead input never renders, and expose canReply on the
test-facing RenderedProposal with an E2E assertion.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

benstull merged commit 611a18016a into main

2026-06-11 06:26:34 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: benstull/vscode-cowriting-plugin#16