vscode-cowriting-plugin

benstull/vscode-cowriting-plugin

Fork 0

Commit Graph

Author	SHA1	Message	Date
Ben Stull	3520397e41	F6 #34 : delete the dead two-pane diff-view UI, keep the baseline data layer F10 (#29) made the rendered preview the single review surface and hid the F6 two-pane vscode.diff view (command + ctrl+alt+d set when:false). This removes that now-unreachable view code: - DiffViewController: drop toggle/findDiffTab/epochLabel/isDiffOpen, the `cowriting-baseline:` TextDocumentContentProvider + BASELINE_SCHEME + baselineUri + the content-provider change emitter, and the toggleDiffView command. The baseline DATA layer is fully intact — ensureBaseline/advance/pin/capture, getBaseline, baselineFilePath, onDidChangeBaseline, persistence (INV-19), and the machine-landing auto-advance (INV-18) that F7/F10 consume. - package.json: remove the toggleDiffView command, its commandPalette entry, and the ctrl+alt+d keybinding. - E2E: diffView suite keeps the baseline-data-layer tests, drops the two-pane view tests; the F10 + no-workspace suites assert toggleDiffView is now absent (was: declared-but-hidden). Deliberate deviation from the issue's literal acceptance: pinDiffBaseline is KEPT. The canonical Solution Design (coauthoring-interactive-review.md §6.7) scopes the removal to the two-pane VIEW only ("keep the controller + baseline store"); pin() lives in the baseline lifecycle (§6.4), never touches vscode.diff, and is exercised by live F7 baseline-reset tests. Where the P3 capture draft and the approved spec conflict, the spec wins (documentation-leads-automation). 194 unit + 49 E2E green; typecheck + build clean. No F7/F10 behavior change. Closes #34 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-12 02:10:14 -07:00
Ben Stull	15d1df0f4c	test(f6): E2E for any-file + untitled diff-view (#19 ) Migrate test surface to URI-string keys; add out-of-workspace file (persisted in global storage) + untitled-buffer (in-memory, not persisted) cases; assert F6 toggle works with no folder open. No LLM. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-11 07:49:05 -07:00
Ben Stull	aed665a978	test(f6): host E2E — toggle, advance-on-accept, pin, persist, untracked (SLICE-4) F6 §6.8. Drives the programmatic seam ingress (propose + accept, no LLM): opened baseline → toggle opens cowriting-baseline diff → type (baseline steady) → accept advances past the landing (INV-18) → operator delta → pin → on-disk baseline outside .threads (INV-19) → toggle closes (normal editor active) → untracked warns. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-11 07:18:23 -07:00

Author

SHA1

Message

Date

Ben Stull

3520397e41

F6 #34 : delete the dead two-pane diff-view UI, keep the baseline data layer

F10 (#29) made the rendered preview the single review surface and hid the F6
two-pane vscode.diff view (command + ctrl+alt+d set when:false). This removes
that now-unreachable view code:

- DiffViewController: drop toggle/findDiffTab/epochLabel/isDiffOpen, the
  `cowriting-baseline:` TextDocumentContentProvider + BASELINE_SCHEME + baselineUri
  + the content-provider change emitter, and the toggleDiffView command. The
  baseline DATA layer is fully intact — ensureBaseline/advance/pin/capture,
  getBaseline, baselineFilePath, onDidChangeBaseline, persistence (INV-19), and
  the machine-landing auto-advance (INV-18) that F7/F10 consume.
- package.json: remove the toggleDiffView command, its commandPalette entry, and
  the ctrl+alt+d keybinding.
- E2E: diffView suite keeps the baseline-data-layer tests, drops the two-pane
  view tests; the F10 + no-workspace suites assert toggleDiffView is now absent
  (was: declared-but-hidden).

Deliberate deviation from the issue's literal acceptance: pinDiffBaseline is
KEPT. The canonical Solution Design (coauthoring-interactive-review.md §6.7)
scopes the removal to the two-pane VIEW only ("keep the controller + baseline
store"); pin() lives in the baseline lifecycle (§6.4), never touches vscode.diff,
and is exercised by live F7 baseline-reset tests. Where the P3 capture draft and
the approved spec conflict, the spec wins (documentation-leads-automation).

194 unit + 49 E2E green; typecheck + build clean. No F7/F10 behavior change.

Closes #34

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-12 02:10:14 -07:00

Ben Stull

15d1df0f4c

test(f6): E2E for any-file + untitled diff-view (#19 )

Migrate test surface to URI-string keys; add out-of-workspace file (persisted
in global storage) + untitled-buffer (in-memory, not persisted) cases; assert
F6 toggle works with no folder open. No LLM.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-06-11 07:49:05 -07:00

Ben Stull

aed665a978

test(f6): host E2E — toggle, advance-on-accept, pin, persist, untracked (SLICE-4)

F6 §6.8. Drives the programmatic seam ingress (propose + accept, no LLM):
opened baseline → toggle opens cowriting-baseline diff → type (baseline steady)
→ accept advances past the landing (INV-18) → operator delta → pin → on-disk
baseline outside .threads (INV-19) → toggle closes (normal editor active) →
untracked warns.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-06-11 07:18:23 -07:00

3 Commits