Native surfaces migration — evolve the extension onto VS Code's native review surfaces (9-task plan, spec v0.2.1) (#72)

test/e2e/suite/authorship.test.ts

@@ -3,6 +3,7 @@ import * as fs from "fs";
 import * as path from "path";
 import * as vscode from "vscode";
 import type { CowritingApi } from "../../../src/extension";
+import { renderHtmlFor } from "./helpers";
 
 const WS = process.env.E2E_WORKSPACE!;
 const settle = () => new Promise((r) => setTimeout(r, 300));
@@ -10,38 +11,39 @@ const settle = () => new Promise((r) => setTimeout(r, 300));
 async function getApi(): Promise<CowritingApi> {
   const ext = vscode.extensions.getExtension("benstull.vscode-cowriting-plugin")!;
   const api = (await ext.activate()) as CowritingApi;
-  assert.ok(api?.trackChangesPreviewController && api?.proposalController, "exports preview + proposal");
+  assert.ok(api?.attributionController && api?.proposalController, "exports attribution + proposal");
   return api;
 }
 
 // F10 host E2E (no LLM): the rewrite of the obsolete F9 authorship-mode test.
 // F9's "authorship" mode / renderAuthorship is gone — the on-state renderReview
-// now author-colors Claude's PENDING proposal blocks as cw-ins-claude. After the
-// proposal is accepted the baseline advances (INV-18/F12) and the text becomes
-// "unchanged" → renders plain. The class to check is cw-ins-claude (proposal block),
-// NOT cw-by-claude (the old F9 authorship render). Owns its own markdown doc.
+// now author-colors Claude's PENDING proposal blocks as cw-ins-claude. This
+// suite checks that render BEFORE accepting (the class to check is cw-ins-claude,
+// the proposal block, NOT cw-by-claude — the old F9 authorship render) and that
+// the attribution data layer survives the accept; it does not exercise the F6
+// baseline (see diffView.test.ts / baselineRouter.test.ts for the post-accept
+// baseline behavior, INV-7/D21). Owns its own markdown doc. Task 8: the render
+// probe is now the pure `renderReview` directly (the webview that used to wrap
+// it, `renderHtmlFor`, is gone).
 suite("F10 review preview — pending Claude proposal renders cw-ins-claude in the on-state (host E2E, no LLM)", () => {
   const DOC_REL = "docs/f10claude.md";
   const TARGET = "The sentence Claude will compose over.";
   const REPLACEMENT = "The sentence CLAUDE COMPOSED via the seam.";
 
-  test("a pending Claude proposal carries cw-ins-claude; accepted proposal leaves attribution data intact; mode defaults to on", async () => {
+  test("a pending Claude proposal carries cw-ins-claude; accepted proposal leaves attribution data intact", async () => {
     const abs = path.join(WS, DOC_REL);
     fs.mkdirSync(path.dirname(abs), { recursive: true });
     fs.writeFileSync(abs, `# F10\n\n${TARGET}\n`, "utf8");
     const uri = vscode.Uri.file(abs);
     const doc = await vscode.workspace.openTextDocument(uri);
     await vscode.window.showTextDocument(doc);
+    // INV-10: entering coediting is required for attribution tracking + F12
+    // optimistic-apply to fire — this suite never entered it (pre-migration).
+    await vscode.commands.executeCommand("cowriting.coeditDocument");
     await settle();
     const api = await getApi();
     const key = uri.toString();
 
-    // open the preview — annotations default ON (F10/INV-33)
-    await vscode.commands.executeCommand("cowriting.showTrackChangesPreview");
-    await settle();
-    assert.ok(api.trackChangesPreviewController.isOpen(key), "preview open");
-    assert.strictEqual(api.trackChangesPreviewController.getMode(key), "on", "annotations default to on");
-
     // Claude proposes via the seam (F12 optimistic-apply; proposal stays PENDING)
     const start = doc.getText().indexOf(TARGET);
     const id = await vscode.commands.executeCommand<string>("cowriting.proposeAgentEdit", {
@@ -59,13 +61,15 @@ suite("F10 review preview — pending Claude proposal renders cw-ins-claude in t
     // PENDING proposal: the preview renders the proposal block with cw-ins-claude.
     // After accepting, the baseline advances (INV-18) → the text becomes "unchanged"
     // and renders plain — so we check BEFORE accepting.
-    const pendingHtml = api.trackChangesPreviewController.renderHtmlFor(key);
+    const pendingHtml = renderHtmlFor(api, doc, key);
     assert.ok(
       pendingHtml.includes("cw-ins-claude"),
       "pending Claude proposal block carries cw-ins-claude in the on-state render",
     );
 
-    // accept via the seam — baseline advances (machine-landing, INV-18/F12)
+    // accept via the seam — the proposal lands; the baseline no longer auto-advances
+    // (INV-18/#48 retired, spec INV-7), but that isn't asserted here (no coediting
+    // entry / baseline established for this doc — only the attribution data layer).
     assert.ok(await api.proposalController.acceptById(DOC_REL, id!), "accept applies via the seam");
     await settle();