benstull/vscode-cowriting-plugin
1
0
Fork 0
Code Issues 9 Pull Requests Actions Packages Projects Releases Wiki Activity

F3 SLICE-5: correct manual-smoke failure-path doc to observed SDK binary discovery (#6)

Browse Source 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ben Stull
2026-06-10 10:27:28 -07:00
parent c08dc075af
commit 258d1fa914
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/MANUAL-SMOKE-F3.md
+10 -4
View File
@@ -28,9 +28,15 @@ the model id, a non-empty `sessionId`, and exits 0.
## 3. Failure paths (INV-8 — graceful, tracking unaffected)
- Signed out / no Claude Code: `PATH="" npm run smoke:live` (or sign out) →
the script exits 1 with a clear error; in-editor, the command shows an
error notification and NO edit is applied.
- Signed out / no Claude Code: hard to simulate on a machine where Claude
Code is installed — neither stripping `PATH` nor hiding the
`~/.local/bin/claude` symlink works (the SDK discovers the real install
under `~/.local/share/claude/versions/…`). The only true trigger is being
signed out (or having no installation at all), so exercise this on a
signed-out machine when one is available. Expected: the script exits 1
with a clear error (`runEditTurn` throws on any non-`completed` run
status); in-editor, the command shows an error notification and NO edit is
applied.
- Buffer edited mid-turn: start an edit-selection turn, type elsewhere in the
document before it completes → warning notification "document changed", no
partial application (stale `expectedVersion`, spec §6.9).
@@ -39,4 +45,4 @@ the model id, a non-empty `sessionId`, and exits 0.
| Date | Machine | Result |
| --- | --- | --- |
| 2026-06-10 | benstull mac (darwin) | PASS — `replacement: "The smoke test passed."`, model `sonnet`, sessionId `run_g_rYKGYl`, 6.9s, exit 0. Failure-path note: with `PATH="/usr/bin:/bin"` the turn STILL succeeded (6.2s) — the SDK resolves `claude` via an absolute path (`~/.local/bin/claude`), not PATH, so a stripped PATH does not exercise the signed-out error; sign out of Claude Code to exercise it for real. |
| 2026-06-10 | benstull mac (darwin) | PASS — `replacement: "The smoke test passed."`, model `sonnet`, sessionId `run_g_rYKGYl`, 6.9s, exit 0. Failure-path notes: turn still succeeded with `PATH="/usr/bin:/bin"` (6.2s) AND with `~/.local/bin/claude` renamed away (3.7s, `run_TQwQipJx`) — the SDK discovers the real install under `~/.local/share/claude/versions/…`, so only a genuine sign-out (not attempted from inside a live session) exercises the error path. |