feat(simulator): /api/alteration + /api/clips; retire selection endpoints

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

tests/test_simulator_api.py

@@ -1,102 +1,90 @@
+import json
+
 import pytest
 from fastapi.testclient import TestClient
 
-from hef.catalog import Record
 from simulator.app import create_app
 
 
-def make_record(**overrides):
-    base = dict(
-        id="r",
-        title="t",
-        source_url="u",
-        source_archive="internet_archive",
-        license="public_domain",
-        mode="video",
-        left=0,
-        right=0,
-        dark=0,
-        light=0,
-        duration_s=600,
-        file_path="",
-    )
-    base.update(overrides)
-    return Record(**base)
+@pytest.fixture
+def manifest_path(tmp_path):
+    p = tmp_path / "manifest.json"
+    p.write_text(json.dumps({
+        "clips": [{
+            "id": "forest",
+            "title": "neutral forest",
+            "base_file": "forest/base.mp4",
+            "license": "poc", "source": "hef-poc",
+            "right_variants": {"4": {"file": "forest/right4.mp4"}},
+            "annotations": [{"key": "detected.water", "box": [0.1, 0.2, 0.3, 0.4], "min_level": 1}],
+            "strings": {"en": {"detected.water": "flowing water"}},
+        }]
+    }))
+    return p
 
 
 @pytest.fixture
-def client():
-    records = [
-        make_record(id="v-near", mode="video", left=0, right=0, dark=0, light=0),
-        make_record(id="v-far", mode="video", left=4, right=4, dark=4, light=4),
-        make_record(id="a-one", mode="audio", left=1, right=1, dark=1, light=1),
-        make_record(id="prop", mode="video", left=0, right=0, dark=0, light=1,
-                    review_status="proposed"),
-        make_record(id="appr", mode="video", left=0, right=0, dark=0, light=1,
-                    review_status="approved"),
-    ]
-    return TestClient(create_app(records=records))
+def client(manifest_path):
+    return TestClient(create_app(manifest_path=manifest_path))
 
 
-def _body(**overrides):
-    base = dict(left=0, right=0, dark=0, light=0, mode="video")
-    base.update(overrides)
-    return base
+def _controls(content="video", left=0, right=0, dark=0, light=0, volume=2, brightness=2):
+    return dict(content=content, left=left, right=right, dark=dark,
+                light=light, volume=volume, brightness=brightness)
 
 
-def test_select_returns_pick_and_ranked_pool(client):
-    resp = client.post("/api/select", json=_body(mode="video", pool_size=4))
+def test_alteration_returns_the_engine_plan(client):
+    resp = client.post("/api/alteration", json={"controls": _controls(left=4, right=2, dark=4)})
     assert resp.status_code == 200
     data = resp.json()
-    assert data["pick"]["id"] == "v-near"
-    ids = [c["record"]["id"] for c in data["pool"]]
-    assert ids[0] == "v-near"
-    assert all("distance" in c and "rank" in c for c in data["pool"])
-    assert [c["rank"] for c in data["pool"]] == list(range(1, len(data["pool"]) + 1))
+    assert data["plan"]["overlay"]["level"] == 4
+    assert data["plan"]["restyle"]["variant"] == 2
+    assert data["plan"]["grade"]["tone"] == -1.0
+    assert data["content"]["video"] is True
 
 
-def test_none_mode_is_the_void(client):
-    resp = client.post("/api/select", json=_body(mode="none"))
-    assert resp.status_code == 200
+def test_alteration_honors_off_as_black(client):
+    resp = client.post("/api/alteration", json={"controls": _controls(content="off")})
     data = resp.json()
-    assert data["pick"] is None
-    assert data["pool"] == []
+    assert data["content"]["video"] is False
 
 
-def test_dial_out_of_range_is_rejected(client):
-    resp = client.post("/api/select", json=_body(left=7))
+def test_alteration_accepts_calibration(client):
+    body = {"controls": _controls(light=4),
+            "calibration": {"mood_gain": 0.5, "overlay_gain": 1.0, "right_variant_map": [0, 1, 2, 3, 4]}}
+    resp = client.post("/api/alteration", json=body)
+    assert resp.json()["plan"]["grade"]["tone"] == 0.5
+
+
+def test_alteration_rejects_out_of_range_knob(client):
+    resp = client.post("/api/alteration", json={"controls": _controls(left=7)})
     assert resp.status_code == 422
 
 
-def test_bad_mode_is_rejected(client):
-    resp = client.post("/api/select", json=_body(mode="banana"))
+def test_alteration_rejects_bad_content(client):
+    resp = client.post("/api/alteration", json={"controls": _controls(content="banana")})
     assert resp.status_code == 422
 
 
-def test_approved_only_narrows_pool(client):
-    resp = client.post("/api/select", json=_body(left=0, right=0, dark=0, light=1,
-                                                 mode="video", approved_only=True))
-    data = resp.json()
-    assert all(c["record"]["review_status"] == "approved" for c in data["pool"])
-
-
-def test_catalog_meta_reports_counts(client):
-    resp = client.get("/api/catalog/meta")
+def test_clips_returns_the_manifest(client):
+    resp = client.get("/api/clips")
     assert resp.status_code == 200
     data = resp.json()
-    assert data["total"] == 5
-    assert data["by_mode"]["video"] == 4
-    assert data["by_mode"]["audio"] == 1
-    assert set(data["by_status"]) == {"proposed", "approved"}
+    assert data["clips"][0]["id"] == "forest"
+    assert data["clips"][0]["right_variants"]["0"]["file"] == "forest/base.mp4"
+    assert data["clips"][0]["annotations"][0]["key"] == "detected.water"
 
 
-from simulator.app import create_app as _create_app_for_static
+def test_retired_selection_endpoints_are_gone(client):
+    # The route no longer exists; the static catch-all yields 404 on GET and
+    # 405 on the (now-unrouted) POST. Either proves the endpoint is gone.
+    assert client.post("/api/select", json={}).status_code in (404, 405)
+    assert client.get("/api/catalog/meta").status_code == 404
 
 
 def test_index_is_served():
-    # The default app mounts the real static dir.
-    client = TestClient(_create_app_for_static())
+    client = TestClient(create_app())
     resp = client.get("/")
     assert resp.status_code == 200
     assert "text/html" in resp.headers["content-type"]
-    assert "X-ray" in resp.text
+    assert "Alteration" in resp.text